-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/claire elastic test #153
Conversation
This reverts commit 6d4f96e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 정리 좋아요. 좀더 개선해 봅시다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 정리하고 가쥬
추가적으로 검토할일 |
어제 리뷰해주셨던 부분들 수정했습니다.
추가적으로, ElasticSearch Document에 따르면, 'typeless APIs will return the dummy type _doc in the response' 버전을 명확하게 나누기 위해 좀 더 찾아보겠습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했어요~
리뷰해주신 부분들 수정했습니다! |
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test: test searchEngine Instances